1.5.1: Test files are being installed by mistake

[leres]

Working on the FreeBSD zeek port, it was reported that test files from the bundled version of spicy are being installed that should not. For example:

include/hilti/rt/3rdparty/SafeInt/Archive/releases/4/SafeInt_3014p.hpp
include/hilti/rt/3rdparty/SafeInt/Archive/releases/4/SafeInt_gcc.hpp
include/hilti/rt/3rdparty/SafeInt/Archive/releases/5/SafeInt_gcc.hpp
include/hilti/rt/3rdparty/SafeInt/Archive/releases/6/SafeInt_gcc.h
include/hilti/rt/3rdparty/SafeInt/Archive/releases/6/SafeInt_3012p.hpp
include/hilti/rt/3rdparty/SafeInt/Archive/releases/7/SafeInt_3011p.hpp
include/hilti/rt/3rdparty/SafeInt/Archive/releases/0/SafeInt_3017p.hpp
include/hilti/rt/3rdparty/SafeInt/Archive/releases/1/SafeInt_3016p.hpp
include/hilti/rt/3rdparty/SafeInt/Archive/releases/2/TestMain.h
include/hilti/rt/3rdparty/SafeInt/Archive/releases/3/SafeInt_3015p.hpp
include/hilti/rt/3rdparty/SafeInt/Test/TestMain.h

There are also a number of empty directories installed:

include/hilti/rt/3rdparty/SafeInt/Archive/releases/8
include/hilti/rt/3rdparty/SafeInt/Archive/releases/4
include/hilti/rt/3rdparty/SafeInt/Archive/releases/5
include/hilti/rt/3rdparty/SafeInt/Archive/releases/6
include/hilti/rt/3rdparty/SafeInt/Archive/releases/7
include/hilti/rt/3rdparty/SafeInt/Archive/releases/0
include/hilti/rt/3rdparty/SafeInt/Archive/releases/1
include/hilti/rt/3rdparty/SafeInt/Archive/releases/2
include/hilti/rt/3rdparty/SafeInt/Archive/releases/3
include/hilti/rt/3rdparty/SafeInt/Archive/sourceCode
include/hilti/rt/3rdparty/SafeInt/Archive/wiki/Render/1909658
include/hilti/rt/3rdparty/SafeInt/Archive/discussions
include/hilti/rt/3rdparty/SafeInt/Archive/issues/15237
include/hilti/rt/3rdparty/SafeInt/Archive/issues/8791
include/hilti/rt/3rdparty/SafeInt/Archive/issues/6534
include/hilti/rt/3rdparty/SafeInt/Archive/issues/6711
include/hilti/rt/3rdparty/SafeInt/Archive/issues/6710
include/hilti/rt/3rdparty/SafeInt/Archive/issues/6642
include/hilti/rt/3rdparty/SafeInt/Archive/issues/6645
include/hilti/rt/3rdparty/SafeInt/Archive/issues/6609
include/hilti/rt/3rdparty/SafeInt/Archive/issues/16816
include/hilti/rt/3rdparty/SafeInt/Archive/issues/17676
include/hilti/rt/3rdparty/SafeInt/Archive/issues/17629
include/hilti/rt/3rdparty/SafeInt/Archive/issues/17327
include/hilti/rt/3rdparty/SafeInt/Archive/issues/7910
include/hilti/rt/3rdparty/SafeInt/Archive/issues/14278
include/hilti/rt/3rdparty/SafeInt/Archive/issues/13029
include/hilti/rt/3rdparty/SafeInt/Archive/license
include/hilti/rt/3rdparty/SafeInt/Test/GccTest
include/hilti/rt/3rdparty/SafeInt/Test/ClangTest
include/hilti/rt/3rdparty/SafeInt/Test/SafeIntTestVS17/SafeIntTestVS17
include/hilti/rt/3rdparty/SafeInt/Test/SafeIntTestVS17/CompileTest
include/hilti/rt/3rdparty/SafeInt/Test/SafeIntTestVS17/Scratch
include/hilti/rt/3rdparty/SafeInt/Test/SafeIntTest/CompileTest
include/zeek/builtin-plugins/spicy-plugin/bin
include/zeek/builtin-plugins/spicy-plugin/cmake
include/zeek/builtin-plugins/spicy-plugin/include/zeek-spicy/autogen
include/zeek/builtin-plugins/spicy-plugin/spicy
include/zeek/builtin-plugins/spicy-plugin/src
include/zeek/builtin-plugins/spicy-plugin/src/compiler
include/zeek/builtin-plugins/spicy-plugin/tests/Scripts
include/zeek/script_opt/CPP/maint
lib/zeek-spicy/modules

It would be nice to eliminate these.

[bbannier]

I opened #1268 to prevent installation of the SafeInt files and directories.

Regarding the empty folders with spicy-plugin in their name, I can only reproduce this if I change a build with Spicy enabled (default) to one disabled with --disable-spicy after the fact; I do not see this issue in a clean build.

I see an empty directory include/zeek/script_opt/CPP/maint as well, but this is something which should be fixed in Zeek proper.