Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpui: Fix for setting window titles on Windows #21907

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

YUCLing
Copy link
Contributor

@YUCLing YUCLing commented Dec 12, 2024

Windows requires WM_NCCREATE to be processed by default procedure to set window title properly.

Release Notes:

  • N/A

This comment was marked as resolved.

@YUCLing

This comment was marked as resolved.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 12, 2024
Copy link

cla-bot bot commented Dec 12, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant changed the title Fix: Unable to set window title on Windows Fix not being unable to set window title on Windows Dec 12, 2024
@maxdeviant maxdeviant changed the title Fix not being unable to set window title on Windows Fix not being able to set window title on Windows Dec 12, 2024
@notpeter notpeter changed the title Fix not being able to set window title on Windows gpui: Fix for setting window titles on Windows Dec 12, 2024
@mikayla-maki
Copy link
Contributor

Thank you!

@mikayla-maki mikayla-maki merged commit 5de0bcc into zed-industries:main Dec 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants