Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary unsafe block warning #20774

Closed
wants to merge 1 commit into from

Conversation

zelenevn
Copy link

Closes #20773

Release Notes:

  • N/A

Copy link

cla-bot bot commented Nov 16, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @zelenevn on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zelenevn
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 16, 2024
Copy link

cla-bot bot commented Nov 16, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant
Copy link
Member

Thank you for the PR, but removing this unsafe block requires Rust 1.82, which we have not yet upgraded to.

The PR for upgrading to that version of Rust is here: #19349

Zed should always be built with the version of Rust specified in our rust-toolchain.toml:

channel = "1.81"

@maxdeviant maxdeviant closed this Nov 16, 2024
@zelenevn zelenevn deleted the fix-warning branch November 16, 2024 20:16
@zelenevn
Copy link
Author

@maxdeviant Hello! Thank you very much for the explanations. I'm sorry, I didn't know about that; I'll be more careful next time. Locally, I am indeed using version 1.82.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary unsafe block warning
2 participants