-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trigger parameter hints #4879
Comments
Is this the same thing as the LSP hover action? |
yes |
there is a slight difference that it can be displayed until it goes out of the scope of the function argument, and it can be switched to show all overloaded function signatures |
Hey @0x2CA, we do have a keybinding to show the hover popup, but I dont think this is quite what you are asking for? |
@JosephTLyons Something like this, but this is not what I want. It should be triggered inside () and show which parameter is currently in |
This feature is called "Signature Help" (https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_signatureHelp) -- it usually displays the signature of a method in a tooltip when a user types the parameter list start character. It looks like it is not supported in zed yet, verified with clangd as well (I didn't see any "signatureHelp" request sent to clangd in the clangd log) |
It seems quite close to #5155. The referenced issue proposes the hint to be displayed automatically while writing a function call, while this issue seems to request just some way (including manual trigger) for this hint. Anyway, just bumping this thing up as it is super-helpful feature. Hopefully, gpui2 will help with implementing it) Also, in discussions there was the comment suggesting that displaying documentation hints while typing is not supported. Hopefully, it would get some attention too 🙏 |
I was honestly surprised this feature was missing - it took me a while to find this issue. |
@m4es7r0 I don't think |
The editor should have this feature. |
#12909 brought initial support for this feature which is almost complete but only shows a single, first signature help it gets (and also does not show description labels, just the signatures). This works well for many languages that have no overrides, so I'll let the PR close this issue automatically and will wait for more feedback in separate issues. This is planned to be released as part of Zed 0.145 |
Check for existing issues
Describe the feature
in vscode ,you can use
Shift ⇧
+Cmd ⌘
+Space
triggerThis is very useful, especially if I forget what arguments does the function take
I use vim mode,I would like to be able to allow auto-prompt as you type, or use a keyboard shortcut, hopefully compared to vim
If applicable, add mockups / screenshots to help present your vision of the feature
No response
The text was updated successfully, but these errors were encountered: