Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redact_private_values setting is not always respected #20676

Closed
1 task done
KhazAkar opened this issue Nov 14, 2024 · 5 comments · Fixed by #21861
Closed
1 task done

redact_private_values setting is not always respected #20676

KhazAkar opened this issue Nov 14, 2024 · 5 comments · Fixed by #21861
Labels
bug [core label] editor Feedback for code editing, formatting, editor iterations, etc linux security & privacy Data privacy issue, security vulnerabilities, etc workspace Feedback for workspace management, layout, interactions, etc

Comments

@KhazAkar
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

When opening .env file with this option set to true (it's disabled by default, why?), values are still being shown

Environment

Zed: v0.161.2 (Zed)
OS: Linux Wayland ubuntu 22.04
Memory: 15.2 GiB
Architecture: x86_64
GPU: Intel(R) UHD Graphics 620 (WHL GT2) || Intel open-source Mesa driver || Mesa 23.2.1-1ubuntu3.1~22.04.2

If applicable, add mockups / screenshots to help explain present your vision of the feature

image

If applicable, attach your Zed.log file to this issue.

No response

@KhazAkar KhazAkar added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Nov 14, 2024
@notpeter
Copy link
Member

I can reproduce. Steps:

Add "redact_private_values": true, to your Zed settings.

mkdir -p /tmp/20676
cd $_
echo "FOO=BAR" > .env
zed .env

Note for redact_private_values works as expected I open the file open inside a workspace instead of as a singleton: zed . .env instead of zed .env.

@notpeter notpeter changed the title redact_private_values setting is not respected redact_private_values setting is not respected outside of workspace Nov 14, 2024
@notpeter notpeter added workspace Feedback for workspace management, layout, interactions, etc editor Feedback for code editing, formatting, editor iterations, etc security & privacy Data privacy issue, security vulnerabilities, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Nov 14, 2024
@KhazAkar
Copy link
Author

To be honest, that file was in workspace, I needed to cut screenshot due to privacy reason :)

@KhazAkar
Copy link
Author

KhazAkar commented Nov 15, 2024

Inside workspace doesn't work for me, too.
image

@notpeter notpeter changed the title redact_private_values setting is not respected outside of workspace redact_private_values setting is always respected Nov 15, 2024
@notpeter
Copy link
Member

notpeter commented Nov 15, 2024

Can confirm:

  • On MacOS it only works inside a workspace, but not for orphan files
  • On Linux it doesn't work at all.

@notpeter notpeter added the linux label Nov 15, 2024
@notpeter notpeter changed the title redact_private_values setting is always respected redact_private_values setting is not always respected Nov 15, 2024
@KhazAkar
Copy link
Author

It seems that this issue is WM/DE dependent. Right now, .env file in workspace is respected, but I'm running sway, not GNOME Wayland, on my another machine.
20241116_15h42m30s_grim

cole-miller added a commit that referenced this issue Dec 12, 2024
Closes #20676

Release Notes:

- Fixed private files not being redacted when not part of a larger
worktree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] editor Feedback for code editing, formatting, editor iterations, etc linux security & privacy Data privacy issue, security vulnerabilities, etc workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants