-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redact_private_values setting is not always respected #20676
Labels
bug
[core label]
editor
Feedback for code editing, formatting, editor iterations, etc
linux
security & privacy
Data privacy issue, security vulnerabilities, etc
workspace
Feedback for workspace management, layout, interactions, etc
Comments
KhazAkar
added
admin read
Pending admin review
bug
[core label]
triage
Maintainer needs to classify the issue
labels
Nov 14, 2024
I can reproduce. Steps: Add mkdir -p /tmp/20676
cd $_
echo "FOO=BAR" > .env
zed .env Note for |
notpeter
changed the title
redact_private_values setting is not respected
redact_private_values setting is not respected outside of workspace
Nov 14, 2024
notpeter
added
workspace
Feedback for workspace management, layout, interactions, etc
editor
Feedback for code editing, formatting, editor iterations, etc
security & privacy
Data privacy issue, security vulnerabilities, etc
and removed
triage
Maintainer needs to classify the issue
admin read
Pending admin review
labels
Nov 14, 2024
To be honest, that file was in workspace, I needed to cut screenshot due to privacy reason :) |
notpeter
changed the title
redact_private_values setting is not respected outside of workspace
redact_private_values setting is always respected
Nov 15, 2024
Can confirm:
|
notpeter
changed the title
redact_private_values setting is always respected
redact_private_values setting is not always respected
Nov 15, 2024
cole-miller
added a commit
that referenced
this issue
Dec 12, 2024
Closes #20676 Release Notes: - Fixed private files not being redacted when not part of a larger worktree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
[core label]
editor
Feedback for code editing, formatting, editor iterations, etc
linux
security & privacy
Data privacy issue, security vulnerabilities, etc
workspace
Feedback for workspace management, layout, interactions, etc
Check for existing issues
Describe the bug / provide steps to reproduce it
When opening
.env
file with this option set to true (it's disabled by default, why?), values are still being shownEnvironment
Zed: v0.161.2 (Zed)
OS: Linux Wayland ubuntu 22.04
Memory: 15.2 GiB
Architecture: x86_64
GPU: Intel(R) UHD Graphics 620 (WHL GT2) || Intel open-source Mesa driver || Mesa 23.2.1-1ubuntu3.1~22.04.2
If applicable, add mockups / screenshots to help explain present your vision of the feature
If applicable, attach your Zed.log file to this issue.
No response
The text was updated successfully, but these errors were encountered: