Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry opt-out #1986

Closed
Tracked by #1701 ...
JosephTLyons opened this issue Dec 20, 2022 · 0 comments
Closed
Tracked by #1701 ...

Telemetry opt-out #1986

JosephTLyons opened this issue Dec 20, 2022 · 0 comments
Assignees
Labels

Comments

@JosephTLyons
Copy link
Collaborator

JosephTLyons commented Dec 20, 2022

One of the beta blockers is adding the option to disable telemetry. I figure I would take this on, but had a few questions I wanted to ask others:

  1. Should we just put if checks within the telemetry object or make the telemetry object optional to the client? I like the idea of the second option, as it bypasses the telemetry code higher up, which is probably cleaner and more efficient, but it comes at the cost of asking the user to restart the application when changing the setting, as setting the optional telemetry object happens during the init of the client.
  2. Do we want to remove the command to check the telemetry log when a user opts out of telemetry? I think there are reasons to justify either option. Keeping it in would let the user check the telemetry log and make sure it is empty, to give the user a bit more assurance that we aren't sending anything. Some might like the idea of just getting it out of there for the sake of clarity.

I'll likely jump on this task soon, so it doesn't fall to the end of the task list and end up actually blocking beta. I plan to either:

  1. Add the setting to the list of settings that don't get autocompleted when the user types in the settings file, so it isn't known that this exists, or
  2. Omit adding the setting aspect of it, and only add the bypass code for now. I'd follow up with a PR to add the setting closer to the time where we went to officially add the feature.
@JosephTLyons JosephTLyons self-assigned this Dec 20, 2022
@JosephTLyons JosephTLyons mentioned this issue Dec 20, 2022
48 tasks
@JosephTLyons JosephTLyons changed the title Disable Telemetry Telemetry opt out Dec 20, 2022
@JosephTLyons JosephTLyons changed the title Telemetry opt out Telemetry opt-out Dec 20, 2022
@maxbrunsfeld maxbrunsfeld mentioned this issue Jan 11, 2023
79 tasks
@mikayla-maki mikayla-maki mentioned this issue Jan 11, 2023
3 tasks
This was referenced Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants