Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to latest commits where possible #19602

Closed
1 task done
Angelk90 opened this issue Oct 23, 2024 · 5 comments
Closed
1 task done

Update dependencies to latest commits where possible #19602

Angelk90 opened this issue Oct 23, 2024 · 5 comments
Labels
open source Open source community projects, contributions, etc support User support (non-defect troubleshooting, documentation, etc) unactionable

Comments

@Angelk90
Copy link

Check for existing issues

  • Completed

Describe the feature

Going to see the Cargo.toml file there are some dependencies that are not updated to the last commit, here is a list of dependencies where possible where there are no conflict issues it would be useful to keep the dependencies updated.

rep: alacritty
Last commit: 2112e90f0dcb77a60b3ef68f3b48e5320ad46de6

rep: blade
Last commit: 8aa5985a123d98ed2da42c7bfa6f290e7423d1e0

rep: reqwest
Last commit: 95fec09be9503d82c574f94e37dde0a814d1f850

rep: tree-sitter-markdown
Last commit: 5cdc549ab8f461aff876c5be9741027189299cec

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@Angelk90 Angelk90 added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Oct 23, 2024
@osiewicz
Copy link
Contributor

It's not necessarily straightforward to upgrade deps. Just because there's no conflict doesn't mean that there won't be any problems with upgrades, as there can be behavioral changes.
For example, I try to get us to new Rust version as soon as possible; #19349 has been open for almost a week because there's one test that changed behavior between language versions.
Another example is our recent bump of taffy version, which caused a performance regression: #19189
So overall, I wouldn't say that this should be a high priority.

@Angelk90
Copy link
Author

@osiewicz : I created an issue from monitor, so that I can remember that there are dependencies that are not updated and in the future I will know when it will be possible to update them and which ones they are, without having to examine all of them.

@SomeoneToIgnore
Copy link
Contributor

We have a bot to track that: https://github.com/zed-industries/zed/pulls?q=is%3Apr+is%3Aclosed+author%3Aapp%2Frenovate so why another issue be better than some status report from it?

@Angelk90
Copy link
Author

@SomeoneToIgnore : Among the External crates of those I indicated in the pr I do not see that the bots have noticed them, take alacritty_terminal, I do not see it.

Current commit refers to Aug 16, subsequently there have been 24 commits to the repository.

@osiewicz
Copy link
Contributor

Would you mind tracking that on your fork then? This issue isn't really about Zed as a product and overall I don't really see why it couldn't be a gist/an issue on a fork.

@notpeter notpeter added open source Open source community projects, contributions, etc unactionable support User support (non-defect troubleshooting, documentation, etc) and removed enhancement [core label] triage Maintainer needs to classify the issue admin read Pending admin review labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open source Open source community projects, contributions, etc support User support (non-defect troubleshooting, documentation, etc) unactionable
Projects
None yet
Development

No branches or pull requests

4 participants