Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in hover documentation #15462

Open
1 task done
valentinegb opened this issue Jul 30, 2024 · 2 comments
Open
1 task done

Images in hover documentation #15462

valentinegb opened this issue Jul 30, 2024 · 2 comments
Labels
documentation [core label] enhancement [core label] image viewer Feedback for image preview, zoom, manipulation, etc markdown Markdown markup support popovers Feedback for tooltips, syntax hints, info popups, toasts, etc

Comments

@valentinegb
Copy link
Contributor

Check for existing issues

  • Completed

Describe the feature

It would be quite nice if Zed showed images in hover documentation. For example, I have the following documentation for a Rust constant:

/// ![](https://cdn.discordapp.com/emojis/1263605189995266058.gif?quality=lossless)
#[cfg(debug_assertions)]
pub(crate) const A_FLOOF_LOAD: &str = "<a:afloofLoad:1263605189995266058>";

Which when built with cargo doc, renders like this:

Screenshot 2024-07-29 at 10 37 01 PM

However, when hovering over the constant in Zed, it currently looks like this:

Screenshot 2024-07-29 at 10 40 52 PM

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@valentinegb valentinegb added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Jul 30, 2024
@notpeter notpeter added documentation [core label] markdown Markdown markup support image viewer Feedback for image preview, zoom, manipulation, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jul 30, 2024
@notpeter
Copy link
Member

Related issue to add inline image support to Markdown Preview:

@notpeter notpeter added the popovers Feedback for tooltips, syntax hints, info popups, toasts, etc label Jul 30, 2024
@valentinegb
Copy link
Contributor Author

Related issue to add inline image support to Markdown Preview:

Oh whoops, I actually thought images were already supported in Zed's Markdown previews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation [core label] enhancement [core label] image viewer Feedback for image preview, zoom, manipulation, etc markdown Markdown markup support popovers Feedback for tooltips, syntax hints, info popups, toasts, etc
Projects
None yet
Development

No branches or pull requests

2 participants