Patching Sigma Generator creation #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psolstice
requested changes
Jul 14, 2019
psolstice
previously approved these changes
Jul 14, 2019
psolstice
previously approved these changes
Jul 15, 2019
psolstice
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A concern was brought up on the public verifiability of the randomness of g in the Sigma generator. While we aren't aware of how this can be exploited as there is no discrete log relationship between g and h, the team agreed that it was best practice to have the generation of g publicly verifiable.
This PR makes g as a hash of the base point of secp256k1 library.