Add warning before dumpwallet is executed #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a-bezrukov Please double check if changing the dumpwallet command by adding a string at the end as per Yura's request or to add a dialog box would break any compatibility with Electrum / Insight before we merge this. |
a-bezrukov
requested review from
psolstice
and removed request for
a-bezrukov
psolstice
requested changes
Oct 17, 2018
psolstice
approved these changes
Oct 18, 2018
|
don't forget to manually test on Windows |
|
Tested on Win7 and Win8, all cases provide random OTAC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue described here: #290
Currently the text is @reubenyap 's warning.