Improve test_uint32_rotr to exercise the by = by % 32 line. #99
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
stefandeml
pushed a commit
to stefandeml/sapling-crypto
that referenced
this pull request
Jul 5, 2019
* modify seal function to be callable from cgo - can't pass arrays by value in C; need to pass pointer to first cell - seal accepts pointer to result-array so that callers manage memory instead of Rust * line reorg * rename symbol * apply cargo fmt * add comments for seal parameters * create lib crate-type for Rust tests * dylib seems to work with cgo * kick off ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first line of
rotrwas changed tolet by = by % 33, for example, then the existing test wouldn't catch the bug.