Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill CurveExt and CurveAffine traits #41

Open
str4d opened this issue May 31, 2022 · 0 comments
Open

Kill CurveExt and CurveAffine traits #41

str4d opened this issue May 31, 2022 · 0 comments

Comments

@str4d
Copy link
Contributor

str4d commented May 31, 2022

These were helper traits that we created to provide additional methods needed for halo2_proofs that the group crate traits didn't have, while we figured out what those needed additional methods were. Now that we've cut halo2_proofs 0.1.0, we need to finish the job:

  • Figure out how to better abstract these additional methods.
  • Add these abstractions to group.
  • Delete the CurveExt and CurveAffine traits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@str4d