Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose diversifier column from sapling_received_notes in the v_tx_outputs view #1073

Open
AArnott opened this issue Dec 22, 2023 · 1 comment

Comments

@AArnott
Copy link
Contributor

AArnott commented Dec 22, 2023

The diversifier should be exposed in the 'public' view so that wallets can recover the original diversifier index used to generate the address that was used to send money to this wallet.

@AArnott
Copy link
Contributor Author

AArnott commented Dec 23, 2023

Alternatively, since it turns out to take a bucketload of code to recreate the address from the diversifier, instead of exposing the diversifier, maybe just populate the to_address column of v_tx_outputs for inbound notes? If folks really want the diversifier, they can always derive it from the address.

Amusingly, the diversifier index is ultimately what I need for my use case. But I already have all the code I need to switch between address, diversifier and diversifier index, and the most user friendly and consistent thing to do here in this crate IMO would be to just populate the column you already have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant