Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HamburgerMenu: Refactoring #767

Open
jvaclavik opened this issue Nov 14, 2024 · 2 comments
Open

HamburgerMenu: Refactoring #767

jvaclavik opened this issue Nov 14, 2024 · 2 comments
Assignees
@jvaclavik
Labels
refactoring

Comments

@jvaclavik
Copy link
Collaborator

  • unify hamburger menu with Profile (icon should be profile icon)
  • refactor icons without necessity of overriding components
image
@jvaclavik jvaclavik self-assigned this Nov 14, 2024
@jvaclavik jvaclavik mentioned this issue Nov 14, 2024
Merged
3 tasks
@zbycz
Copy link
Owner

zbycz commented Nov 14, 2024

I would like to keep current state (two buttons) on desktop and only do the mentioned refactoring for MobileMode. Do you agree?

@jvaclavik
Copy link
Collaborator Author

I would like to keep current state (two buttons) on desktop and only do the mentioned refactoring for MobileMode. Do you agree?

I disagree, because I think it's counterintuitive to group it this way. We shouldn't teach our users on two buttons and then keep the same icon but add content from different section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvaclavik jvaclavik

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zbycz @jvaclavik @Dlurak