Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ideas for better performance #2

Closed
zbraniecki opened this issue May 14, 2019 · 3 comments
Closed

Ideas for better performance #2

zbraniecki opened this issue May 14, 2019 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zbraniecki
Copy link
Owner

zbraniecki commented May 14, 2019 •
edited
Loading

In projectfluent/fluent-langneg-rs#7 @raphlinus suggested changes to how we store Strings to improve performance of the Locale struct.

I think we can now hold this conversation here, as I want to carve out Locale struct/trait from fluent-locale-rs.
@zbraniecki
Copy link
Owner Author

Some options include smallstring, istring, smol_str etc.

@zbraniecki zbraniecki added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 6, 2019
@emilio
Copy link
Contributor

emilio commented Aug 7, 2019

Seems like projectfluent/fluent-langneg-rs#8 had a very nice proof of concept.

@zbraniecki
Copy link
Owner Author

fixed in 378718b

for future ideas let's open new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zbraniecki @emilio