-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
published cubes don't pass validation for schema:publisher
, schema:creator
nor schema:contributor
#1501
Comments
@giacomociti considering
I'd temporarily skip theese 3 predicates by commenting them rather than enforcing them until further clarification cc @CDiGallo feel free to add your remarks and guidance |
Hi |
or +1 what thomas said |
whichever @CDiGallo prefers. |
not sure what is the chosen solution then |
I recap my understanding of the issue: before publishing a cube, CC checks it with standalone-constraint-constraint ( The online cube validator instead checks cubes with either standalone-cube-constraint, profile-opendataswiss or profile-visualize. Each of these profiles imports standalone-constraint-constraint and adds more shapes: standalone-cube-constraint adds a shape ( profile-opendataswiss adds a shape ( profile-visualize additional shapes don't require (yet) any publisher, creator, or contributor. The problem is that cubes created with CC lack such properties. CC optionally allows setting My understanding is that, as a short-term solution, we can treat the missing properties as warnings. Later on, we can enhance CC. But if my understanding is correct, the changes should be applied to standalone-cube-constraint in the cube.link repo. |
so I changed the severity in cube schema, see it in cube validator |
published cubes don't pass validation for
schema:publisher
,schema:creator
norschema:contributor
applied by https://github.com/zazuko/cube-link/blob/main/validation/standalone-cube-constraint.ttlDescribe the bug
To Reproduce
Steps to reproduce the behavior:
Observed Violation
Violation of MinCountConstraintComponent: "cube:Cube needs an schema:publisher" with path http://schema.org/publisher at focus node https://environment.ld.admin.ch/foen/besch_holz_inst_einheit_weniger4/20 (source: _:b88_b697)
Violation of MinCountConstraintComponent: "cube:Cube needs an schema:creator" with path http://schema.org/creator at focus node https://environment.ld.admin.ch/foen/besch_holz_inst_einheit_weniger4/20 (source: _:b88_b698)
Violation of MinCountConstraintComponent: "cube:Cube needs an schema:contributor" with path http://schema.org/contributor at focus node https://environment.ld.admin.ch/foen/besch_holz_inst_einheit_weniger4/20 (source: _:b88_b706)
Expected behavior
no violations
cc @ClaudioDiGallo
The text was updated successfully, but these errors were encountered: