Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added to last release #37

Closed
yevmoroz opened this issue Oct 16, 2020 · 2 comments · Fixed by #55
Closed

Added to last release #37

yevmoroz opened this issue Oct 16, 2020 · 2 comments · Fixed by #55

Comments

@yevmoroz
Copy link

It would be a good addition to changelog action to validate if added entry goes to last release (even unreleased) block. Fail otherwise.

@gotbahn
Copy link
Contributor

gotbahn commented Nov 17, 2020

Lemme give some examples that should fail:

  1. Wrong version was patched
## 1.9.1 - 15.01.2077

Hotfix description

### 2.0.0 - 01.01.2077

Release description

### 1.9.0 - 01.01.2025

Release description

...
  1. Version was added in wrong timeline
### 2.0.0 - 01.01.2077

Release description

## 2.1.0 - 15.01.2077

Hotfix description

### 1.9.0 - 01.01.2025

Release description

...
  1. Unreleased version placed between released versions
### 2.0.0 - 01.01.2077

Release description

## Unreleased

Hotfix description

### 1.9.0 - 01.01.2025

Release description

...
  1. Merge conflict added by mistake same versions
### 2.0.0 - 01.01.2077

Release description

### 2.0.0 - 01.01.2077

Release description

### 1.9.0 - 01.01.2025

Release description

...

Examples are quite different, so maybe it make sense introduce one by one

@gotbahn
Copy link
Contributor

gotbahn commented Nov 19, 2020

and another one, this time valid one

If pre-release has greater version, it's fine

### 2.2.0 - 01.01.2077

Release description

### 3.0.0-rc.0 - 01.01.2055

Release description

### 2.1.0 - 01.01.2025

Release description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants