Wrap sync fs for xarray.to_zarr #2533
Draft
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automatically wraps synchronous filesystems in the
RemoteStore.from_url
function. This is necessary unless we provide aforce_async
argument onfsspec
surl_to_fs
function.I'm not sure adding more flags (even if we sugar them with default values) is the best move. Another option might be to implement a
url_to_asyncfs
method that simply wrapsurl_to_fs
and wraps any synchronous filesystems that come out automatically but that, too, would require changes here.This PR is in service of downstream kerchunk compatibility: fsspec/kerchunk#516
It depends on: fsspec/filesystem_spec#1755