Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap sync fs for xarray.to_zarr #2533

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

moradology
Copy link

@moradology moradology commented Dec 4, 2024

This PR automatically wraps synchronous filesystems in the RemoteStore.from_url function. This is necessary unless we provide a force_async argument on fsspecs url_to_fs function.

I'm not sure adding more flags (even if we sugar them with default values) is the best move. Another option might be to implement a url_to_asyncfs method that simply wraps url_to_fs and wraps any synchronous filesystems that come out automatically but that, too, would require changes here.

This PR is in service of downstream kerchunk compatibility: fsspec/kerchunk#516

It depends on: fsspec/filesystem_spec#1755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant