Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipStore tests may not identify bugs involving get and set #2692

Open
maxrjones opened this issue Jan 13, 2025 · 1 comment
Open

ZipStore tests may not identify bugs involving get and set #2692

maxrjones opened this issue Jan 13, 2025 · 1 comment

Comments

@maxrjones
Copy link
Member

The set and get methods for StoreTests should be independently implemented but the ZipStore tests use the store methods, meaning that the behavior will be tested against itself rather than the expected behavior. This issue is to decide if the get and set methods for TestZipStore should be changed to not use ZipStore methods.

@d-v-b
Copy link
Contributor

d-v-b commented Jan 13, 2025

good catch, I would recommend implementing separate test-suite-only get and set methods, as per the other stores

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants