Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous benchmarking with ASV #126

Open
alimanfoo opened this issue Nov 19, 2018 · 6 comments
Open

Continuous benchmarking with ASV #126

alimanfoo opened this issue Nov 19, 2018 · 6 comments

Comments

@alimanfoo
Copy link
Member

It would be great to implement ASV or similar so we catch any changes that introduce a performance regression.

@alimanfoo alimanfoo added this to the v0.7.0 milestone Nov 30, 2018
@jakirkham
Copy link
Member

@joshmoore this was something we were looking at right?

@joshmoore
Copy link
Member

@jakirkham, yes, during the last GSOC round. There are a few decisions to be made and then various functions to be written, but pretty straight-forward.

@jeromekelleher
Copy link
Member

Just FYI, it's worth having a look at upstream discussions about the future of the project (e.g. airspeed-velocity/asv#1219 ) before committing to ASV

@joshmoore
Copy link
Member

Oh wow. Thanks for the heads up, @jeromekelleher! (Yet another reason it was sad to have missed the summit.) I'll keep an eye on it, but in our testing with asv so far (for zarr-python) there was already one "speed regression" identified. (By another "j" programmer who shall rename nameless.) So it might make sense to get something in place soonish, with the understanding that we will be up for jumping ship when the time comes.

@JackKelly
Copy link

Just following up on this: Were any benchmarks implemented for numcodecs? If so, did the benchmarks use ASV?

it's worth having a look at upstream discussions about the future of the project (e.g. airspeed-velocity/asv#1219 ) before committing to ASV

For context: I'm currently researching benchmarking tools for benchmarking zarr-python. ASV looked good. Until I saw that discussion!

@joshmoore
Copy link
Member

In the context of GSOC asv was only implemented for zarr-python and there only superficially.

@dstansby dstansby removed this from the v0.7.0 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants