Switching netcdf3 & netcdf4 filetype detection to file magic 🧙

[norlandrhagen]

#43 (comment)

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.48%. Comparing base (2c5be3f) to head (757c571).

Files	Patch %	Lines
virtualizarr/kerchunk.py	71.42%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   90.29%   90.48%   +0.18%     
==========================================
  Files          14       14              
  Lines         938      946       +8     
==========================================
+ Hits          847      856       +9     
+ Misses         91       90       -1     

Flag	Coverage Δ
unittests	90.48% <75.00%> (+0.18%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rabernat]

This function should return an enum, not a string.

Everything in this library should be super strictly typed.

[norlandrhagen]

@rabernat Should these be similar to how it's done in pangeo-forge-recipes?, ie.

class FileType(AutoName):
    netcdf3 = auto()
    netcdf4 = auto()
    grib = auto()


...

filetype = FileType("netcdf3")

[TomNicholas]

I think this looks good!

[norlandrhagen]

Sounds good, ready to merge?

[TomNicholas]

Thanks again @norlandrhagen !