Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude empty paths on ChunkDict creation #198

Merged

Conversation

ghidalgo3
Copy link
Contributor

@ghidalgo3 ghidalgo3 commented Jul 19, 2024

This was discovered while experimenting with GOES data, kudos to @t-mcneely for discovering this. We think there's a small bug in the filter expression during ChunkDict creation. Ultimately this caused a problem when reading/writing kerchunk stores of the data.

Here's a neat image rendering the chunk grid we were working with, note how the corners are empty:
Screenshot 2024-07-19 171140

  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst

@ghidalgo3 ghidalgo3 marked this pull request as ready for review July 19, 2024 21:17
@TomNicholas TomNicholas merged commit 10ef7e5 into zarr-developers:main Jul 20, 2024
7 checks passed
@TomNicholas
Copy link
Member

Thanks!

FYI I'm currently actually road-tripping and just occasionally looking at all the great PRs you are raising from my phone... Let me know if it would be useful to give more people push access.

@ghidalgo3 ghidalgo3 deleted the guhidalgo/handleemptypaths branch July 20, 2024 14:40
@ghidalgo3
Copy link
Contributor Author

Enjoy your road trip! If you could give @TomAugspurger access, I trust him to review my changes, but please don't feel like you need to keep up with PRs on the road. I can always work off a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants