Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuse_attr needs blksize #38

Closed
akiradeveloper opened this issue Jan 25, 2015 · 6 comments
Closed

fuse_attr needs blksize #38

akiradeveloper opened this issue Jan 25, 2015 · 6 comments

Comments

@akiradeveloper
Copy link

Current rust-fuse doesn't have blksize field in fuse_attr struct.

Is this a bug?

struct fuse_attr {
        __u64   ino;
        __u64   size;
        __u64   blocks;
        __u64   atime;
        __u64   mtime;
        __u64   ctime;
        __u32   atimensec;
        __u32   mtimensec;
        __u32   ctimensec;
        __u32   mode;
        __u32   nlink;
        __u32   uid;
        __u32   gid;
        __u32   rdev;
        __u32   blksize;
        __u32   padding;
};
@cuviper
Copy link
Contributor

cuviper commented Jan 25, 2015

Well, rust-fuse declares itself using protocol 7.8 (FUSE_KERNEL_VERSION and FUSE_KERNEL_MINOR_VERSION), but Linux only added blksize starting in protocol 7.9 with commit 0e9663ee452ff, released in Linux 2.6.24. I'm not sure what OSX has.

@akiradeveloper
Copy link
Author

I see. So that's not a bug. But, being adherent to that old version sounds no good to users.

@akiradeveloper
Copy link
Author

But supporting 7.8 protocol sounds reasonable if you construct a simple fuse binding.
Yeah, my nim-fuse will follow you.

@zargony
Copy link
Owner

zargony commented Jan 27, 2015

Release 2.7.4 of OSXFUSE seems to be at protocol version 7.8: [header]
The master branch however seems to have unreleased stuff for protocol version up to 7.19: [header]

@kahing
Copy link

kahing commented Sep 10, 2017

I wonder if it's because of protocol versions that -o atomic_o_trunc also doesn't work?

@zargony
Copy link
Owner

zargony commented Sep 19, 2017

fuse_attr.blksize and FUSE_ATOMIC_O_TRUNC were both introduced in 7.9, we're still using 7.8 unfortunately.
I started to work on supporting a newer protocol in PR #97. It's targeting protocol 7.19 which seems to be well supported by Linux and macOS.

@zargony zargony closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants