WIP: Update fuse mount methods to take AsRef<OsStr> as options #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fuse::mount and fuse::spawn_mount to take generic AsRef<OsStr> as options argument.
wfraser
reviewed
Jul 11, 2019
| let args = vec![ | ||
| CString::new("rust-fuse").unwrap(), | ||
| CString::new(options.to_str().unwrap()).unwrap() | ||
| ]; |
There was a problem hiding this comment.
This is a change in behavior: the current code passes FUSE a list of N arguments; this code always gives it only 2 arguments, where everything after the first is combined into one string. This doesn't actually work correctly; if you play with the example a bit, you'll notice that everything past the first space character gets ignored by FUSE.
There was a problem hiding this comment.
Thanks for the feedback. Ill mark the PR as WIP while I take a look at this.
There was a problem hiding this comment.
👍 a good way to test this is by passing --help as one of the arguments. libfuse will print its usage text if it sees that.
krishna-veerareddy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fuse::mount and fuse::spawn_mount to take generic AsRef
as options argument.
Fixes #117