-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add noWait field to yaml for manifests and charts #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corang
added
needs-docs
PR Label - Docs required to merge
needs-tests
PR Label - Tests required to merge
labels
Sep 29, 2022
corang
commented
Sep 29, 2022
corang
changed the title
add new example for no wait
Add noWait field to yaml for manifests and charts
Oct 3, 2022
Racer159
requested changes
Oct 5, 2022
Racer159
approved these changes
Oct 5, 2022
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description Add field to zarf.yaml to support not waiting for charts and manifests. Fixes #766 ## Type of change <!-- Please delete options that are not relevant --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) ## Checklist before merging <!-- Please delete options that are not relevant --> - [x] Tests have been added/updated as necessary (add the `needs-tests` label) - [x] Documentation has been updated as necessary (add the `needs-docs` label) - [ ] (Optional) Changes have been linted locally with [golangci-lint](https://github.com/golangci/golangci-lint). (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.) Co-authored-by: Megamind <[email protected]> Co-authored-by: Wayne Starr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add field to zarf.yaml to support not waiting for charts and manifests.
Fixes #766
Type of change
Checklist before merging
needs-tests
label)needs-docs
label)