Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noWait field to yaml for manifests and charts #816

Merged
merged 13 commits into from
Oct 5, 2022

Conversation

corang
Copy link
Contributor

@corang corang commented Sep 29, 2022

Description

Add field to zarf.yaml to support not waiting for charts and manifests.

Fixes #766

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)
  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

@corang corang added needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge labels Sep 29, 2022
@corang corang changed the title add new example for no wait Add noWait field to yaml for manifests and charts Oct 3, 2022
@corang corang removed the needs-tests PR Label - Tests required to merge label Oct 3, 2022
@corang corang removed the needs-docs PR Label - Docs required to merge label Oct 3, 2022
@corang corang marked this pull request as ready for review October 4, 2022 20:11
examples/helm-no-wait/README.md Outdated Show resolved Hide resolved
examples/helm-no-wait/never-ready.pod.yaml Outdated Show resolved Hide resolved
src/test/e2e/28_wait_test.go Outdated Show resolved Hide resolved
src/test/e2e/28_wait_test.go Outdated Show resolved Hide resolved
@corang corang enabled auto-merge (squash) October 5, 2022 19:36
@corang corang merged commit ccd26d6 into master Oct 5, 2022
@bdfinst bdfinst deleted the conditional-wait-766 branch January 12, 2023 22:33
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
## Description

Add field to zarf.yaml to support not waiting for charts and manifests.

Fixes #766 

## Type of change

<!-- Please delete options that are not relevant -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)

## Checklist before merging

<!-- Please delete options that are not relevant -->

- [x] Tests have been added/updated as necessary (add the `needs-tests`
label)
- [x] Documentation has been updated as necessary (add the `needs-docs`
label)
- [ ] (Optional) Changes have been linted locally with
[golangci-lint](https://github.com/golangci/golangci-lint). (NOTE: We
haven't turned on lint checks in the pipeline yet so linting may be hard
if it shows a lot of lint errors in places that weren't touched by
changes. Thus, linting is optional right now.)

Co-authored-by: Megamind <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

post-install hooks do not get ran until all chart resources are ready/healthy
3 participants