Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpack tarball and remove by name #814

Merged

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Sep 29, 2022

Description

Adds functionality to provide a tarball path in zarf package remove <name | path>. Unpacks given tarball temporarily to grab zarf.yaml > .Metadata.Name as the name to use in packager.Remove(<name>).

Related Issue

Fixes #742

Type of change

  • New feature (non-breaking change which adds functionality)

@Noxsios Noxsios linked an issue Sep 29, 2022 that may be closed by this pull request
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test?

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@jeff-mccoy jeff-mccoy enabled auto-merge (squash) October 1, 2022 06:36
@jeff-mccoy jeff-mccoy merged commit abb391b into master Oct 1, 2022
@bdfinst bdfinst deleted the 742-remove-deployed-packages-by-pathing-to-the-tarball branch January 12, 2023 22:33
Noxsios added a commit that referenced this pull request Mar 8, 2023
## Description

Adds functionality to provide a tarball path in `zarf package remove
<name | path>`. Unpacks given tarball temporarily to grab `zarf.yaml >
.Metadata.Name` as the name to use in `packager.Remove(<name>)`.

## Related Issue

Fixes #742 

## Type of change

- [x] New feature (non-breaking change which adds functionality)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deployed packages by pathing to the tarball
3 participants