-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpack tarball and remove by name #814
unpack tarball and remove by name #814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks!
## Description Adds functionality to provide a tarball path in `zarf package remove <name | path>`. Unpacks given tarball temporarily to grab `zarf.yaml > .Metadata.Name` as the name to use in `packager.Remove(<name>)`. ## Related Issue Fixes #742 ## Type of change - [x] New feature (non-breaking change which adds functionality)
Description
Adds functionality to provide a tarball path in
zarf package remove <name | path>
. Unpacks given tarball temporarily to grabzarf.yaml > .Metadata.Name
as the name to use inpackager.Remove(<name>)
.Related Issue
Fixes #742
Type of change