Support git repo caching on package create #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the 'external' git server still exists within the k8s cluster, create a tunnel when pushing repos to it
general cleanup and oranization of functions in hooks package for zarf agent
Makes sure the svc url comes at the end of the provided URL. This captures edge cases where someone has a subdomain that looks just like a service url would. eg) https://svc.cluster.local.example.com
update GitHub workflows to not explicitly create init-package if it's not needed (if it already exists)
The get-admin-password was a bad name because it wasn't clear what 'admin' meant. We are now making the name more explicit
update the flag git-username to git-account and add a note in the usage text to describe what to do if the repository belongs under an org
verify that the git-user and git-password has been provided if using an external git server
give users the ability to set some of the flags for the GitServerInfo without needing to host an extneral repository
ready check now verifies that the zarf-state has been loaded by verifying the distro field has been populated
instead of essentially hardcoding the container URL to be localhost:31999 we are now loading the containger registry information from the zarf state to get the address of the registry
instead of having a single 'secret' value and expanding that into other secrets for internal resources, we now store all the values necessary within the ZarfState
…to-the-image-cache-directory
Racer159
commented
Oct 3, 2022
…to-the-image-cache-directory
…to-the-image-cache-directory
…to-the-image-cache-directory
jeff-mccoy
reviewed
Oct 4, 2022
jeff-mccoy
reviewed
Oct 4, 2022
jeff-mccoy
reviewed
Oct 4, 2022
jeff-mccoy
reviewed
Oct 4, 2022
jeff-mccoy
reviewed
Oct 4, 2022
jeff-mccoy
reviewed
Oct 4, 2022
jeff-mccoy
reviewed
Oct 4, 2022
Switched to using os.TempDir instead of /tmp if that helps? |
jeff-mccoy
reviewed
Oct 4, 2022
UncleGedd
pushed a commit
that referenced
this pull request
Oct 6, 2022
## Description Add the ability to locally cache large git repositories when pulling them with Zarf ## Related Issue Fixes #750 ## Type of change - [X] New feature (non-breaking change which adds functionality) ## Checklist before merging - [x] Tests have been added/updated as necessary (add the `needs-tests` label) - [x] Documentation has been updated as necessary (add the `needs-docs` label) - [x] An ADR has been written as necessary (add the `needs-adr` label) [ [1](https://github.com/joelparkerhenderson/architecture-decision-record) [2](https://cognitect.com/blog/2011/11/15/documenting-architecture-decisions) [3](https://adr.github.io/) ] - [x] (Optional) Changes have been linted locally with [golangci-lint](https://github.com/golangci/golangci-lint). (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.) Co-authored-by: Jon Perry <[email protected]> Co-authored-by: Megamind <[email protected]>
bdfinst
deleted the
750-support-a-git-cache-directory-similar-to-the-image-cache-directory
branch
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description Add the ability to locally cache large git repositories when pulling them with Zarf ## Related Issue Fixes #750 ## Type of change - [X] New feature (non-breaking change which adds functionality) ## Checklist before merging - [x] Tests have been added/updated as necessary (add the `needs-tests` label) - [x] Documentation has been updated as necessary (add the `needs-docs` label) - [x] An ADR has been written as necessary (add the `needs-adr` label) [ [1](https://github.com/joelparkerhenderson/architecture-decision-record) [2](https://cognitect.com/blog/2011/11/15/documenting-architecture-decisions) [3](https://adr.github.io/) ] - [x] (Optional) Changes have been linted locally with [golangci-lint](https://github.com/golangci/golangci-lint). (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.) Co-authored-by: Jon Perry <[email protected]> Co-authored-by: Megamind <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to locally cache large git repositories when pulling them with Zarf
Related Issue
Fixes #750
Type of change
Checklist before merging
needs-testslabel)needs-docslabel)needs-adrlabel) [ 1 2 3 ]