Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reintroduce postgres operator example database pods #233

Merged
merged 8 commits into from
Jan 27, 2022

Conversation

wadedesir
Copy link
Contributor

@wadedesir wadedesir commented Jan 19, 2022

Should fix #201 It appears the postgres-cluster yaml was not present in the newer versions of this example and thus the database pods were not being created accordingly.

@wadedesir wadedesir force-pushed the postgress-operator-example-fix branch from 6fdd42c to 09e89f3 Compare January 19, 2022 16:11
@YrrepNoj
Copy link
Contributor

Do you happen to know around which commit this yaml was removed in? I'm curious if it was an accident or if we were trying to do something different/specific that didn't work the way we expected.

Copy link
Contributor

@RothAndrew RothAndrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Clean up the warning in the readme saying this example doesn't work

Copy link
Contributor

@RothAndrew RothAndrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting an ImagePullBackoff. Make sure the pod spec has the imagePullSecret in its config

image

image

@wadedesir
Copy link
Contributor Author

Do you happen to know around which commit this yaml was removed in? I'm curious if it was an accident or if we were trying to do something different/specific that didn't work the way we expected.

@YrrepNoj looks like they were removed with commit f96ae20 / #144

  • Clean up the warning in the readme saying this example doesn't work

Will do

Getting an ImagePullBackoff. Make sure the pod spec has the imagePullSecret in its config

@RothAndrew That's weird. They were coming up fine without it on my end. Let's take a look at it together when you have some time but try the new changes in the meantime.

@RothAndrew
Copy link
Contributor

@wadedesir still getting ImagePullBackOff. See this github issue.

Not sure why you aren't getting it. Are you using the vagrantfile that modifies the hosts file of the VM? If you aren't then it will just pull directly from the upstream registry and won't need authorization for the internal zarf docker registry.

@wadedesir
Copy link
Contributor Author

@RothAndrew @YrrepNoj Everything should be working as expected now.

@RothAndrew
Copy link
Contributor

RothAndrew commented Jan 24, 2022

Screenshot coming in from @wadedesir. Through debugging it sounds like you can't configure imagePullSecrets or a different service account for the pooler pod, but we found this github issue that talks about patching the default serviceaccount in that namespace. I recommended that we do that same thing but as a scripts.after: script in the component in the package's zarf.yaml

@wadedesir
Copy link
Contributor Author

Screenshot coming in from @wadedesir. Through debugging it sounds like you can't configure imagePullSecrets or a different service account for the pooler pod, but we found this github issue that talks about patching the default serviceaccount in that namespace. I recommended that we do that same thing but as a scripts.after: script in the component.
Screen Shot 2022-01-24 at 3 43 29 PM

@YrrepNoj
Copy link
Contributor

/test all

@RothAndrew RothAndrew merged commit 7f79352 into master Jan 27, 2022
@RothAndrew RothAndrew deleted the postgress-operator-example-fix branch January 27, 2022 22:14
jeff-mccoy pushed a commit that referenced this pull request Feb 8, 2022
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The postgres-operator example doesn't quite work
3 participants