Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the selection between CMD and Powershell and prefer CMD for dataInjections #1581

Merged
merged 14 commits into from
Apr 17, 2023

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Apr 8, 2023

Description

This allows package creators to select between cmd and powershell for actions and prefers cmd over powershell for dataInjections.

Related Issue

Fixes #N/A

More info: https://kubernetes.slack.com/archives/C03B6BJAUJ3/p1680880810057189?thread_ts=1680097325.822069&cid=C03B6BJAUJ3

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Apr 8, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 642f45f
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6439d9dbd83a5000083f21ba
😎 Deploy Preview https://deploy-preview-1581--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Racer159
Copy link
Contributor Author

Racer159 commented Apr 8, 2023

Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do we want to add integration to defaults now or later?

@Racer159
Copy link
Contributor Author

It is integrated with defaults.

YrrepNoj
YrrepNoj previously approved these changes Apr 14, 2023
@Noxsios Noxsios self-requested a review April 14, 2023 21:34
@Racer159 Racer159 merged commit 3ec78a8 into main Apr 17, 2023
@Racer159 Racer159 deleted the allow-choice-of-cmd-vs-powershell branch April 17, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants