-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setVariables, indent and sensitive variables implementation #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
added
needs-docs
PR Label - Docs required to merge
needs-tests
PR Label - Tests required to merge
labels
Mar 23, 2023
Racer159
requested review from
mike-winberry,
Noxsios,
jeff-mccoy,
YrrepNoj,
Madeline-UX,
JasonvanBrackel,
RothAndrew,
wirewc and
a team
as code owners
March 23, 2023 20:23
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Racer159
changed the title
Initial setVariables and sensitive variables implementation
Initial setVariables, indent and sensitive variables implementation
Mar 23, 2023
YrrepNoj
suggested changes
Mar 31, 2023
YrrepNoj
approved these changes
Mar 31, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an initial setVariables implementation and sensitive variables implementation from some of the conversations coming out of #1473
Related Issue
Relates to #1473
Fixes: #1165
Type of change
Checklist before merging