Docs: fixed broken links #1386
Merged
Docs: fixed broken links #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tand-the-basics.md file.
TheFutonEng
requested review from
Madeline-UX,
JasonvanBrackel,
RothAndrew,
jeff-mccoy,
YrrepNoj and
Racer159
as code owners
✅ Deploy Preview for zarf-docs canceled.
|
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description Stumbled across some broken links in [this doc](https://github.com/defenseunicorns/zarf/blob/main/docs/1-understand-the-basics.md). Dug through the [commit history](https://github.com/defenseunicorns/zarf/pull/1276/files#diff-53706aae2f95773ebd248f8d0d160403083ffc18ba649f08ebb35e806c5cd797) and pulled out the correct links. Tossed the `documentation` label on the PR, not sure but hope that prevents any pipelines from kicking off. I didn't see anything in the contributor's guide to tackle a doc update. Please advise if this PR is suitable. FYI @bdfinst ## Related Issue Fixes # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed Co-authored-by: Bryan Finster <[email protected]>
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description Stumbled across some broken links in [this doc](https://github.com/defenseunicorns/zarf/blob/main/docs/1-understand-the-basics.md). Dug through the [commit history](https://github.com/defenseunicorns/zarf/pull/1276/files#diff-53706aae2f95773ebd248f8d0d160403083ffc18ba649f08ebb35e806c5cd797) and pulled out the correct links. Tossed the `documentation` label on the PR, not sure but hope that prevents any pipelines from kicking off. I didn't see anything in the contributor's guide to tackle a doc update. Please advise if this PR is suitable. FYI @bdfinst ## Related Issue Fixes # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed Co-authored-by: Bryan Finster <[email protected]> Signed-off-by: razzle <[email protected]>
Racer159
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description Stumbled across some broken links in [this doc](https://github.com/defenseunicorns/zarf/blob/main/docs/1-understand-the-basics.md). Dug through the [commit history](https://github.com/defenseunicorns/zarf/pull/1276/files#diff-53706aae2f95773ebd248f8d0d160403083ffc18ba649f08ebb35e806c5cd797) and pulled out the correct links. Tossed the `documentation` label on the PR, not sure but hope that prevents any pipelines from kicking off. I didn't see anything in the contributor's guide to tackle a doc update. Please advise if this PR is suitable. FYI @bdfinst ## Related Issue Fixes # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed Co-authored-by: Bryan Finster <[email protected]> Signed-off-by: Wayne Starr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stumbled across some broken links in this doc. Dug through the commit history and pulled out the correct links. Tossed the
documentationlabel on the PR, not sure but hope that prevents any pipelines from kicking off. I didn't see anything in the contributor's guide to tackle a doc update. Please advise if this PR is suitable.FYI @bdfinst
Related Issue
Fixes #
Type of change
Checklist before merging