Add prerequisites check and delete flag support for the longhorn package #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonvanBrackel
requested review from
Madeline-UX,
RothAndrew,
jeff-mccoy,
YrrepNoj and
Racer159
as code owners
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jeff-mccoy
reviewed
Feb 23, 2023
jeff-mccoy
reviewed
Feb 23, 2023
|
@jeff-mccoy @Racer159 Items are resolved. Can you give this another look, please? |
Racer159
requested changes
Mar 4, 2023
Remove extra "how" from the readme file. Co-authored-by: Wayne Starr <[email protected]>
Adding a newline to the end of the file Co-authored-by: Wayne Starr <[email protected]>
Moving action for consistency sake Co-authored-by: Wayne Starr <[email protected]>
Moving actions per @Racer159 Co-authored-by: Wayne Starr <[email protected]>
Moving actions per @Racer159 Co-authored-by: Wayne Starr <[email protected]>
Moving actions per @Racer159 Co-authored-by: Wayne Starr <[email protected]>
|
Thanks @Racer159 I like the changes you made, They've been committed and I updated the README.md accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the Longhorn Prerequisite Check to the Longhorn Package Example per https://longhorn.io/docs/1.4.0/deploy/install/#using-the-environment-check-script
Adds the Longhorn Delete Flag Update Per https://longhorn.io/docs/1.4.0/deploy/uninstall/#prerequisite
Environment Check
Delete Flag Change
Type of change
Checklist before merging