-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zarf init
from UI
#1213
Merged
Merged
Fix zarf init
from UI
#1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…nseunicorns/zarf into 1212-unable-to-init-from-ui
Noxsios
requested review from
jeff-mccoy,
YrrepNoj,
Racer159,
mike-winberry,
Madeline-UX,
JasonvanBrackel and
RothAndrew
as code owners
January 19, 2023 04:09
jeff-mccoy
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much cleaner ui testing and finally getting rid of some of the pre-MZAL api init logic is good too. lgtm.
Noxsios
added a commit
that referenced
this pull request
Mar 8, 2023
## Description Due to the changes to `ZarfInitOptions`, `ZarfDeployOptions` and some overarching codebase changes, the UI's backend init process is broken. This PR fixes that flow. - Fix init via UI - Add docs for UI's E2E tests - Add an E2E test to actually run init ## Related Issue Fixes #1212 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the changes to
ZarfInitOptions
,ZarfDeployOptions
and some overarching codebase changes, the UI's backend init process is broken. This PR fixes that flow.Related Issue
Fixes #1212
Type of change
Checklist before merging