Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zarf init from UI #1213

Merged
merged 17 commits into from
Jan 19, 2023
Merged

Fix zarf init from UI #1213

merged 17 commits into from
Jan 19, 2023

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Jan 18, 2023

Description

Due to the changes to ZarfInitOptions, ZarfDeployOptions and some overarching codebase changes, the UI's backend init process is broken. This PR fixes that flow.

  • Fix init via UI
  • Add docs for UI's E2E tests
  • Add an E2E test to actually run init

Related Issue

Fixes #1212

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist before merging

@Noxsios Noxsios added this to the Zarf UI milestone Jan 18, 2023
@Noxsios Noxsios self-assigned this Jan 18, 2023
@Noxsios Noxsios linked an issue Jan 18, 2023 that may be closed by this pull request
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner ui testing and finally getting rid of some of the pre-MZAL api init logic is good too. lgtm.

@jeff-mccoy jeff-mccoy merged commit a36ae72 into main Jan 19, 2023
@jeff-mccoy jeff-mccoy deleted the 1212-unable-to-init-from-ui branch January 19, 2023 10:03
Noxsios added a commit that referenced this pull request Mar 8, 2023
## Description

Due to the changes to `ZarfInitOptions`, `ZarfDeployOptions` and some
overarching codebase changes, the UI's backend init process is broken.
This PR fixes that flow.

- Fix init via UI
- Add docs for UI's E2E tests
- Add an E2E test to actually run init

## Related Issue

Fixes #1212 

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Init from UI
2 participants