Template files #1171
Merged
Template files #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-mccoy
requested review from
mike-winberry,
Racer159,
Noxsios,
YrrepNoj,
Madeline-UX,
JasonvanBrackel,
RothAndrew and
a team
as code owners
|
Added breaking change since the DATA_INJECTION_MARKER change will break any existing data injection packages. EDIT: Nevermind 😅 |
Racer159
reviewed
Jan 9, 2023
Racer159
approved these changes
Jan 9, 2023
Racer159
requested changes
Jan 9, 2023
Racer159
requested changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds variable templating to text files included under the
fileskey in a Zarf Package. This mirrors the existing behavior of Kustomizations, charts, and manifests, except for the case of files called before the Zarf package needs a cluster. In this case, some special variables, such as###ZARF_REGISTRY###will not be available. This was needed because some components with files will be called before a cluster is created, such as in the K3s package.This PR also fixes a typo with the data-injection marker and permits the use of
0-9for variable/constant names in addition toA-Z_.Related to #1129
Related to #1141