Make data injection idempotent #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-mccoy
changed the title
Racer159
requested changes
Dec 5, 2022
…-injection-things
|
updated as requested |
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
This PR addresses some race conditions that can exist when running data injections or performing data injections. Key changes: - Replace `WaitForPodsAndContainers()` second argument, `waitForAllPods` with a new filter function and return all pods found leaving it to the caller to determine any further action (only data injection needed more than one pod) - Properly deal with matching the correct init containers based on the `dataInjectionMarker` so that we don't match other failed installs - Properly validate after injection that at least one pod with the correct `dataInjectionMarker` is now ready - No longer warn and keep going on failure but retry the injection again - Add 3 x data injection tests to ensure idempotence is working as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some race conditions that can exist when running data injections or performing data injections. Key changes:
WaitForPodsAndContainers()second argument,waitForAllPodswith a new filter function and simply return all pods found leaving it to the caller to determine any further action (only data injection needed more than one pod)dataInjectionMarkerso that we don't match other failed installsdataInjectionMarkeris now ready