Fix UI failing silently if init package is not found #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YrrepNoj
suggested changes
Nov 17, 2022
Noxsios
requested review from
Madeline-UX,
JasonvanBrackel and
RothAndrew
as code owners
Madeline-UX
previously approved these changes
Nov 18, 2022
…all API errors are now 500s
YrrepNoj
reviewed
Dec 1, 2022
Noxsios
deleted the
1013-ui-fails-silently-when-init-package-is-not-found
branch
|
@Noxsios I think it would be helpful to add pictures or a video to show any UI fixes |
Noxsios
added a commit
that referenced
this pull request
Mar 8, 2023
## Description Fixes UI failing silently if init package is not found. It is worth noting that this PR introduces some basic JSON error messaging to the API + JSON error message handling in the UI's `http.ts`. ## Related Issue <!--- This project prefers to accept pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> Fixes #1013 ## Type of change <!-- Please delete options that are not relevant --> - [X] Bug fix (non-breaking change which fixes an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes UI failing silently if init package is not found.
It is worth noting that this PR introduces some basic JSON error messaging to the API + JSON error message handling in the UI's
http.ts.Related Issue
Fixes #1013
Type of change