Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deployed packages by pathing to the tarball #742

Closed
YrrepNoj opened this issue Sep 16, 2022 · 0 comments · Fixed by #814
Closed

Remove deployed packages by pathing to the tarball #742

YrrepNoj opened this issue Sep 16, 2022 · 0 comments · Fixed by #814
Assignees
@Noxsios
Labels
good first issue 🥇 Good for newcomers

Comments

@YrrepNoj
Copy link
Contributor

Right now the zarf package remove command requires the argument to be the package name. It would be nice if we expand out the argument functionality so that it can take a path to a Zarf package.

Currently only zarf package remove dos-games --confirm works, this issue is proposing to also allow zarf package remove build/zarf-package-dos-games-amd64.tar.zst.
@YrrepNoj YrrepNoj added the good first issue 🥇 Good for newcomers label Sep 16, 2022
@RothAndrew RothAndrew moved this to New Requests in Zarf Project Board Sep 16, 2022
@JasonvanBrackel JasonvanBrackel moved this from New Requests to Backlog in Zarf Project Board Sep 23, 2022
@Noxsios Noxsios self-assigned this Sep 29, 2022
@Noxsios Noxsios linked a pull request Sep 29, 2022 that will close this issue
unpack tarball and remove by name #814
Merged
1 task
@Noxsios Noxsios mentioned this issue Sep 29, 2022
Merged
1 task
jeff-mccoy pushed a commit that referenced this issue Oct 1, 2022
@Noxsios
unpack tarball and remove by name (#814)
abb391b 
## Description

Adds functionality to provide a tarball path in `zarf package remove
<name | path>`. Unpacks given tarball temporarily to grab `zarf.yaml >
.Metadata.Name` as the name to use in `packager.Remove(<name>)`.

## Related Issue

Fixes #742 

## Type of change

- [x] New feature (non-breaking change which adds functionality)
Repository owner moved this from Backlog to Done in Zarf Project Board Oct 1, 2022
Noxsios added a commit that referenced this issue Mar 8, 2023
@Noxsios
unpack tarball and remove by name (#814)
7eb2517 
## Description

Adds functionality to provide a tarball path in `zarf package remove
<name | path>`. Unpacks given tarball temporarily to grab `zarf.yaml >
.Metadata.Name` as the name to use in `packager.Remove(<name>)`.

## Related Issue

Fixes #742 

## Type of change

- [x] New feature (non-breaking change which adds functionality)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Noxsios Noxsios

Labels
good first issue 🥇 Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unpack tarball and remove by name zarf-dev/zarf
2 participants
@YrrepNoj @Noxsios