Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make utility registry require credentials #5

Closed
RothAndrew opened this issue Sep 7, 2021 · 4 comments · Fixed by #144
Closed

Make utility registry require credentials #5

RothAndrew opened this issue Sep 7, 2021 · 4 comments · Fixed by #144
Assignees

Comments

@RothAndrew
Copy link
Contributor

RothAndrew commented Sep 7, 2021

At the very least, the utility registry should require credentials to push images. Ideally these creds would be dynamically handled similarly to #3.


Migrated from https://repo1.dso.mil/platform-one/big-bang/apps/product-tools/zarf/-/issues/9

@jeff-mccoy
Copy link
Contributor

@RothAndrew this would be a good high value task you could do without code changes I think

@jeff-mccoy
Copy link
Contributor

@RothAndrew moved this up in the roadmap because I feel it's a pretty important / lacking component for Zarf that shouldn't take any significant go changes.

@RothAndrew
Copy link
Contributor Author

I'm planning on this being my next priority when I have more time to work on Zarf stuff. Currently still working on other projects.

@RothAndrew RothAndrew self-assigned this Oct 29, 2021
@RothAndrew
Copy link
Contributor Author

So Docker Registry uses htpasswd for password auth, which uses one-way hashes. Not as simple as just substituting ###ZARF_SECRET### with the password that Zarf creates.

Right now I'm thinking of maybe adding functionality to add parsing of ###ZARF_HTPASSWD### which would result in a proper htpasswd string like zarf-git-user:$2y$05$1oC7e2fbDJaMx7YEHIuPre90KBg2WQRRR2Ag4aE49buP7SQTu9kMS (that's the hash for the password foobar)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants