Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our git logic should be refactored to be simpler and reduce the likelihood of errors being introduced #1405

Closed
Racer159 opened this issue Mar 2, 2023 · 0 comments · Fixed by #1404
Closed

Our git logic should be refactored to be simpler and reduce the likelihood of errors being introduced #1405

Racer159 opened this issue Mar 2, 2023 · 0 comments · Fixed by #1404

Comments

@Racer159
Copy link
Contributor

Racer159 commented Mar 2, 2023

Describe what should be investigated or refactored

Currently our git repository mirroring logic doesn't align well with how git works under the hood and is prone to the introduction of errors as we tweak features. We should refactor this to:

  1. Reduce the number of operations we perform on git repos
  2. Align more directly with how git refs work under the hood
  3. Keep repositories separated from one another in transit
  4. Introduce more tests to catch errors sooner in the future.

Links to any relevant code

https://github.com/defenseunicorns/zarf/tree/main/src/internal/packager/git

Additional context

This is a continuation after #1362 and to help this stuck PR #1094
@Racer159 Racer159 mentioned this issue Mar 2, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this to New Requests in Zarf Project Board Mar 2, 2023
Racer159 added a commit that referenced this issue Mar 3, 2023
@jeff-mccoy @Racer159
Add git branch support, non-linear tag support and simplify git repo …
1588a98 
…logic (#1404)

## Description

This refactors our git logic to be more in line with the goals of #1405 

## Related Issue

Fixes #1405

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
@github-project-automation github-project-automation bot moved this from New Requests to Done in Zarf Project Board Mar 3, 2023
Noxsios pushed a commit that referenced this issue Mar 8, 2023
@jeff-mccoy @Racer159
Add git branch support, non-linear tag support and simplify git repo …
6b4f732 
…logic (#1404)

## Description

This refactors our git logic to be more in line with the goals of #1405 

## Related Issue

Fixes #1405

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Noxsios pushed a commit that referenced this issue Mar 8, 2023
@jeff-mccoy @Racer159 @Noxsios
Add git branch support, non-linear tag support and simplify git repo …
4a89269 
…logic (#1404)

This refactors our git logic to be more in line with the goals of #1405

Fixes #1405

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Racer159 added a commit that referenced this issue Mar 8, 2023
@jeff-mccoy @Racer159
Add git branch support, non-linear tag support and simplify git repo …
41aa660 
…logic (#1404)

This refactors our git logic to be more in line with the goals of #1405

Fixes #1405

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add git branch support, non-linear tag support and simplify git repo logic zarf-dev/zarf
1 participant
@Racer159