Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have separate examples for create-time variables and deploy-time variables #1165

Closed
RothAndrew opened this issue Jan 6, 2023 · 1 comment · Fixed by #1474
Closed

Have separate examples for create-time variables and deploy-time variables #1165

RothAndrew opened this issue Jan 6, 2023 · 1 comment · Fixed by #1474
Labels
documentation 📘 Improvements or additions to documentation
Milestone
v0.26 (m2-4.25)

Comments

@RothAndrew
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I was trying to give a tutorial on deploy-time variables and tried to use the package-variables example in this repo to do it, but it was confusing to the person I was giving the tutorial to because I had to use create-time variables at the same time (i.e. zarf package create --set ACTION=template --set CONFIG_MAP=simple-configmap.yaml) because of the way the example is set up.

Describe the solution you'd like

2 examples exist:

  • One that only uses create-time variables
  • One that only uses deploy-time variables
@github-project-automation github-project-automation bot moved this to New Requests in Zarf Project Board Jan 6, 2023
@Madeline-UX Madeline-UX added this to the Docs Examples milestone Jan 6, 2023
@Noxsios Noxsios added the documentation 📘 Improvements or additions to documentation label Jan 7, 2023
@Racer159 Racer159 modified the milestones: v0.25.x, v0.25.y Feb 26, 2023
@Racer159 Racer159 modified the milestones: v0.25.x, v0.26.x Mar 19, 2023
@Racer159 Racer159 mentioned this issue Mar 27, 2023
Merged
5 tasks
@Racer159
Copy link
Contributor

I believe this will be addressed by #1474

Racer159 added a commit that referenced this issue Mar 31, 2023
@Racer159
Initial setVariables, indent and sensitive variables implementation (#…
3ec5d00 
…1474)

## Description

This is an initial setVariables implementation and sensitive variables
implementation from some of the conversations coming out of #1473

## Related Issue

Relates to  #1473
Fixes: #1165

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
@github-project-automation github-project-automation bot moved this from New Requests to Done in Zarf Project Board Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation 📘 Improvements or additions to documentation
Projects
None yet
Milestone
v0.26 (m2-4.25)
Development

Successfully merging a pull request may close this issue.

Initial setVariables, indent and sensitive variables implementation zarf-dev/zarf
4 participants
@Racer159 @RothAndrew @Noxsios @Madeline-UX