Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Tests are failing on Node 10.5 #342

Closed
eliangcs opened this issue Jul 2, 2018 · 1 comment · Fixed by #435
Closed

Tests are failing on Node 10.5 #342

eliangcs opened this issue Jul 2, 2018 · 1 comment · Fixed by #435
Labels
bug

Comments

@eliangcs
Copy link
Member

eliangcs commented Jul 2, 2018 •
edited
Loading

The tests are failing on Node 10.5 because mock-fs doesn't work on Node 10.5:

tschaub/mock-fs#238

This doesn't affect production usage but is a bit annoying to see a failing Travis badge.

What would you like to change?

We have three options:

  • Replace Node 10 with Node 10.4 in .travis.yml
  • Wait for mock-fs to fix the issue
  • Remove mock-fs from our test code
@eliangcs eliangcs added the bug label Jul 2, 2018
@eliangcs eliangcs mentioned this issue Jul 6, 2018
Merged
@xavdid
Copy link
Contributor

xavdid commented Jul 9, 2018

Seems like no action needed on our part for now

@eliangcs eliangcs mentioned this issue Nov 13, 2018
Merged
@xavdid xavdid mentioned this issue May 29, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump travis node version zapier/zapier-platform-cli
2 participants
@eliangcs @xavdid