From cd066b5e90a7eef62df46a0b491ca9b7558bec08 Mon Sep 17 00:00:00 2001 From: Rossi Sun Date: Fri, 5 Jul 2024 16:59:58 +0800 Subject: [PATCH] GH-43116: [C++][Compute] Mark KeyCompare.CompareColumnsToRowsLarge as large memory test (#43128) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### Rationale for this change This test consumes more than 4GB memory and causes oom-kill when running with TSAN as reported in #43116 . ### What changes are included in this PR? Limit its running by marking it as large memory test. ### Are these changes tested? Change is test. ### Are there any user-facing changes? None. * GitHub Issue: #43116 Authored-by: Ruoxi Sun Signed-off-by: Raúl Cumplido --- cpp/src/arrow/compute/row/compare_test.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cpp/src/arrow/compute/row/compare_test.cc b/cpp/src/arrow/compute/row/compare_test.cc index 662862075c245..22af7e067d855 100644 --- a/cpp/src/arrow/compute/row/compare_test.cc +++ b/cpp/src/arrow/compute/row/compare_test.cc @@ -166,10 +166,9 @@ TEST(KeyCompare, CompareColumnsToRowsTempStackUsage) { } } -#ifndef ARROW_VALGRIND // Compare columns to rows at offsets over 2GB within a row table. // Certain AVX2 instructions may behave unexpectedly causing troubles like GH-41813. -TEST(KeyCompare, CompareColumnsToRowsLarge) { +TEST(KeyCompare, LARGE_MEMORY_TEST(CompareColumnsToRowsLarge)) { if constexpr (sizeof(void*) == 4) { GTEST_SKIP() << "Test only works on 64-bit platforms"; } @@ -300,7 +299,6 @@ TEST(KeyCompare, CompareColumnsToRowsLarge) { num_rows); } } -#endif // ARROW_VALGRIND } // namespace compute } // namespace arrow