Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remark: Hide Installer Output (Commit bce8b) #59

Open
adam-grant-hendry opened this issue Aug 23, 2023 · 3 comments
Open

Remark: Hide Installer Output (Commit bce8b) #59

adam-grant-hendry opened this issue Aug 23, 2023 · 3 comments
Labels
internal Related to implementation details

Comments

@adam-grant-hendry
Copy link

What are the duplicates you're talking about? Was it anything like what was happening here when --ansi color output was being used?

@adam-grant-hendry
Copy link
Author

adam-grant-hendry commented Aug 23, 2023

See poetry issue 3097. This may have been fixed in PR 4660. I saw this was merged Dec 3, 2022, and you made the commit on Sept 17, 2022. It was included in version .1.3.0, so I wonder if it is no longer an issue (at least for poetry>=1.3.0)?

It would be good to add a regression test for this, however.

@zanieb
Copy link
Owner

zanieb commented Aug 24, 2023

Thanks for the comment and references! This is interesting, I'll need to look into it again but I suspect it is resolved as you mentioned.

I don't have a lot of test coverage for the output, it's quite a bit of work to maintain. Maybe I'll look into a snapshot test library for Python.

@zanieb zanieb added the internal Related to implementation details label Aug 24, 2023
@adam-grant-hendry
Copy link
Author

No worries, I understand. I was curious if it was something in the repo or an upstream issue with poetry, so I poked around.

Seems like it would only be an issue with version 1.2 or less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Related to implementation details
Projects
None yet
Development

No branches or pull requests

2 participants