Skip to content

Commit

Permalink
platform/x86/intel: punit_ipc: Drop wrong use of ACPI_PTR()
Browse files Browse the repository at this point in the history
ACPI_PTR() is more harmful than helpful. For example, in this case
if CONFIG_ACPI=n, the ID table left unused which is not what we want.

Instead of adding ifdeffery here and there, drop ACPI_PTR()
and unused acpi.h.

Fixes: fdca4f1 ("platform:x86: add Intel P-Unit mailbox IPC driver")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Hans de Goede <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
  • Loading branch information
andy-shev authored and jwrdegoede committed Sep 13, 2021
1 parent 6880fa6 commit 349bff4
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/platform/x86/intel/punit_ipc.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
* which provide mailbox interface for power management usage.
*/

#include <linux/acpi.h>
#include <linux/bitops.h>
#include <linux/delay.h>
#include <linux/device.h>
Expand Down Expand Up @@ -319,7 +318,7 @@ static struct platform_driver intel_punit_ipc_driver = {
.remove = intel_punit_ipc_remove,
.driver = {
.name = "intel_punit_ipc",
.acpi_match_table = ACPI_PTR(punit_ipc_acpi_ids),
.acpi_match_table = punit_ipc_acpi_ids,
},
};

Expand Down

0 comments on commit 349bff4

Please sign in to comment.