-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constant cookie name for the OIDC filter #3234
Add constant cookie name for the OIDC filter #3234
Conversation
Signed-off-by: Carl Zhou <[email protected]>
Signed-off-by: Carl Zhou <[email protected]>
Signed-off-by: Carl Zhou <[email protected]>
Signed-off-by: Carl Zhou <[email protected]>
Signed-off-by: Carl Zhou <[email protected]>
Signed-off-by: Carl Zhou <[email protected]>
Signed-off-by: Carl Zhou <[email protected]>
Signed-off-by: Carl Zhou <[email protected]>
Signed-off-by: Carl Zhou <[email protected]>
Signed-off-by: Carl Zhou <[email protected]>
I just want to be clear: |
👍 |
1 similar comment
👍 |
Thanks for explaining this. So far we were only able to observe one skipper cookie for the OIDC session. Can you elaborate on cases where there may be multiple cookies? Are these cases only within auth or outside of auth? |
@czhou-brex Thank you for contribution. Next time please rebase and squash your PR on top of the latest master so we do not have github confused and its easier to write release notes as they are composed from all commit messages |
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 Signed-off-by: Roman Zavodskikh <[email protected]>
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 Signed-off-by: Roman Zavodskikh <[email protected]>
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 canary was updated #8214 Signed-off-by: Roman Zavodskikh <[email protected]>
Allow specifying cookie name prefix for OIDC filters Signed-off-by: Carl Zhou <[email protected]>
In order to support the logout filter for OIDC, we are proposing a parameter to make the cookie name a constant, so it can be read accordingly.
This is one of the PRs for #3235
Thanks to @Matheus-Michels for the code.