-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
options: Add RegisterFilters callback #3203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a callback to register additional filters that can also re-use already registered filters. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added
the
major
moderate risk, for example new API, small filter changes that have no risk like refactoring or logs
label
Aug 22, 2024
👍 |
1 similar comment
👍 |
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 26, 2024
Follow up on #3203 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 26, 2024
Test that builtin and CustomFilters are registered before RegisterFilters callback. Follow up on #3203 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 26, 2024
Test that built-in and CustomFilters are registered before RegisterFilters callback. Follow up on #3203 Signed-off-by: Alexander Yastrebov <[email protected]>
szuecs
pushed a commit
that referenced
this pull request
Aug 26, 2024
Test that built-in and CustomFilters are registered before RegisterFilters callback. Follow up on #3203 Signed-off-by: Alexander Yastrebov <[email protected]>
Pushpalanka
pushed a commit
that referenced
this pull request
Oct 11, 2024
Add a callback to register additional filters that can also re-use already registered filters. Signed-off-by: Alexander Yastrebov <[email protected]>
Pushpalanka
pushed a commit
that referenced
this pull request
Oct 11, 2024
Test that built-in and CustomFilters are registered before RegisterFilters callback. Follow up on #3203 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
major
moderate risk, for example new API, small filter changes that have no risk like refactoring or logs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a callback to register additional filters that can also re-use already registered filters.