Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Senza disregard "NoEcho" attribute for parameters when creating default stack description #425

Open
alterrebe opened this issue Dec 29, 2016 · 2 comments

Comments

@alterrebe
Copy link
Contributor

alterrebe commented Dec 29, 2016

Senza creates a default stack description (components/configuration.py, method get_default_description() ) by concatenating the stack name with all the parameters values used to create the stack. The values are shown in clear text even if a particular parameter is defined as NoEcho, so the behavior defeats the purpose of the NoEcho attribute.

Senza should honor the NoEcho attribute and replace such parameters' values with **** in the same way as AWS console does.

@alterrebe
Copy link
Contributor Author

A temporary workaround is to provide an explicit stack description by duplicating the description clause both inside SenzaInfo and on the top level:

SenzaInfo:
   StackName: foo
   Description: some description
   ...

Description: same description

SenzaComponents:
   ...

It prevents Senza from generating the default description. A drawback is that we don't see other parameters values in the stacks list.

@hjacobs
Copy link
Contributor

hjacobs commented Dec 30, 2016

Honoring NoEcho sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants