Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider use of CloudFormation template parameters #454

Open
AlexanderYastrebov opened this issue Nov 19, 2021 · 0 comments
Open

Reconsider use of CloudFormation template parameters #454

AlexanderYastrebov opened this issue Nov 19, 2021 · 0 comments

Comments

@AlexanderYastrebov
Copy link
Member

AlexanderYastrebov commented Nov 19, 2021

CloudFormation template to create load balancers was initially introduced within #42

It seems the idea was to have a static parameterized template. Over the time template generation was translated into the go code #111

Changes cloudformation template from a yaml template to use the library https://github.com/mweagle/go-cloudformation to generate the template using Go. This is needed because we want to dynamically add certificates to the stack, which is not possible with pure cloudformation.

and became more and more conditional.

Since template is in the code now it seems there is no value in having template parameters so we should consider removing them in favor of using values directly to simplify code structure (remove indirection), remove boilrerplate and ease maintenance.

Care must be taken to not trigger massive loadbalancer recreation caused by template change.

@AlexanderYastrebov AlexanderYastrebov changed the title Reconsider CloudFormation template parameters usage Reconsider use of CloudFormation template parameters Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant