Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect change log generated with previous tag not fetched. #65

Open
jimsynz opened this issue Apr 11, 2024 · 3 comments
Open

Incorrect change log generated with previous tag not fetched. #65

jimsynz opened this issue Apr 11, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@jimsynz
Copy link
Contributor

jimsynz commented Apr 11, 2024

I recently did a release of Ash that generated a change log with a heap of extra stuff in it. I'm guessing that it's because I didn't have the previous version's tag fetched locally so the diff was incorrectly generated.

This should probably be detected and the command aborted with an error.

@zachdaniel
Copy link
Owner

I wonder how we could detect this...while semantic versions have meaning between each other, they don't necessarily have an explicit "step" between versions enforce. i.e the next version after 2.1.0-charmander could be 2.2.0-charizard. We could apply a heuristic and warn on common patterns though?

@jimsynz
Copy link
Contributor Author

jimsynz commented Apr 11, 2024

We could just make sure that the tag is present for the version we find in the mix file before we apply any changes.

@zachdaniel
Copy link
Owner

oh, right, duh. That is much simpler!

@zachdaniel zachdaniel added the good first issue Good for newcomers label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants