From 260a66c5ed3009a97dd495593f22e7ed3d10178e Mon Sep 17 00:00:00 2001 From: Yahor Yuzefovich Date: Tue, 21 Feb 2023 10:04:31 -0800 Subject: [PATCH] bench: skip a failing case in BenchmarkFuncExprTypeCheck Informs: #97400. Release note: None --- pkg/bench/bench_test.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/pkg/bench/bench_test.go b/pkg/bench/bench_test.go index 827bcba863ab..0242f247a3bd 100644 --- a/pkg/bench/bench_test.go +++ b/pkg/bench/bench_test.go @@ -1443,7 +1443,8 @@ func BenchmarkFuncExprTypeCheck(b *testing.B) { sqlDB.ExecMultiple(b, `CREATE SCHEMA sc1`, `CREATE SCHEMA sc2`, - `CREATE FUNCTION abs(val INT) RETURNS INT CALLED ON NULL INPUT LANGUAGE SQL AS $$ SELECT val $$`, + // TODO(chengxiong): uncomment this when #97400 is resolved. + //`CREATE FUNCTION abs(val INT) RETURNS INT CALLED ON NULL INPUT LANGUAGE SQL AS $$ SELECT val $$`, `CREATE FUNCTION sc1.udf(val INT) RETURNS INT CALLED ON NULL INPUT LANGUAGE SQL AS $$ SELECT val $$`, `CREATE FUNCTION sc1.udf(val STRING) RETURNS STRING LANGUAGE SQL AS $$ SELECT val $$`, `CREATE FUNCTION sc1.udf(val FLOAT) RETURNS FLOAT LANGUAGE SQL AS $$ SELECT val $$`, @@ -1487,10 +1488,11 @@ func BenchmarkFuncExprTypeCheck(b *testing.B) { name: "builtin aggregate not called on null", exprStr: "concat_agg(NULL)", }, - { - name: "udf same name as builtin", - exprStr: "abs(123)", - }, + // TODO(chengxiong): uncomment this when #97400 is resolved. + //{ + // name: "udf same name as builtin", + // exprStr: "abs(123)", + //}, { name: "udf across different schemas", exprStr: "udf(123)",